/hg/icedtea6: only generate javaws.1 if we want to build docs an...

Omair Majid omajid at redhat.com
Fri Sep 17 08:46:04 PDT 2010


On 09/17/2010 11:37 AM, Matthias Klose wrote:
> On 17.09.2010 16:09, omajid at icedtea.classpath.org wrote:
>> changeset 2713dbdb914e in /hg/icedtea6
>> details:
>> http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=2713dbdb914e
>> author: omajid
>> date: Fri Sep 17 10:07:45 2010 -0400
>>
>> only generate javaws.1 if we want to build docs and the man
>> directory exists
>
> I don't think this is a good idea. --disable-docs is there to save some
> build time, and usually you don't need the docs when building the
> architecture dependent packages packages, but the man pages *are*
> included in these architecture dependent packages. I don't care about
> the time it takes to create the man page, too much micro optimization ;)
>

You certainly have a point. I only added this patch because without it, 
the 'make hotspot' target was causing a build failure. For some reason 
'make hotspot' builds netx and plugin, but not the rest of the jdk or 
the man pages. So the copying of the man pages to 
$(build)/j2sdk-image/man/ would fail. If you think that the javaws man 
pages should be built whether or not --enable-docs is used, I can remove 
the if ENABLE_DOCS check (but we still need the checks for the man 
folder existing).

Cheers,
Omair



More information about the distro-pkg-dev mailing list