/hg/icedtea6: only generate javaws.1 if we want to build docs an...

[Dr Andrew John Hughes]

On 11:46 Fri 17 Sep     , Omair Majid wrote:
> On 09/17/2010 11:37 AM, Matthias Klose wrote:
> > On 17.09.2010 16:09, omajid at icedtea.classpath.org wrote:
> >> changeset 2713dbdb914e in /hg/icedtea6
> >> details:
> >> http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=2713dbdb914e
> >> author: omajid
> >> date: Fri Sep 17 10:07:45 2010 -0400
> >>
> >> only generate javaws.1 if we want to build docs and the man
> >> directory exists
> >
> > I don't think this is a good idea. --disable-docs is there to save some
> > build time, and usually you don't need the docs when building the
> > architecture dependent packages packages, but the man pages *are*
> > included in these architecture dependent packages. I don't care about
> > the time it takes to create the man page, too much micro optimization ;)
> >

I was under the belief that it was failing to copy the man page if DISABLE_DOCS
was set.  If not, then certainly this patch shouldn't be applied.

I don't follow either of your arguments though; this is nothing to do with speed
(the issue is a build breakage) and why are man pages architecture-dependent anyway,
whether they are copied or not?

> 
> You certainly have a point. I only added this patch because without it, 
> the 'make hotspot' target was causing a build failure. For some reason 
> 'make hotspot' builds netx and plugin, but not the rest of the jdk or 
> the man pages.

That's by design.  It's called 'make hotspot' for a reason.  The JDK
should have already been built.  It's not used for production as far
as I'm aware (it seems to be more of a hack for those working on
Zero/Shark) and there seems to be a very simple solution of rebuilding
icedtea-ecj and icedtea rather than icedtea-against-ecj and
icedtea-against-icedtea respectively.

 So the copying of the man pages to 
> $(build)/j2sdk-image/man/ would fail. If you think that the javaws man 
> pages should be built whether or not --enable-docs is used, I can remove 
> the if ENABLE_DOCS check (but we still need the checks for the man 
> folder existing).
> 

I don't think we need the checks either if the man pages are always present.
That would be hiding an earlier build failure.

> Cheers,
> Omair

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8