[RFC][Icedtea-web]: Changed how cache works.

[Omair Majid]

On 04/18/2011 03:06 PM, Andrew Su wrote:
>>
>> Are the markCompressed/isCompressed methods used anywhere? If not,
>> could you please make that a separate patch?
>
> Yes, I've added the use of isCompressed in CacheEntry.isCached().
> Reason being that if the item was extracted, the content-length reported
> by the connection would differ from actual file size, thus forcing it to
> download without actually checking the modified time.
>

That is a problem, but it seems orthogonal to the rest of the patch. I 
am not sure simply ignoring the content-length for compressed files is 
the best thing to do. We wont be able to detect changes in file size. 
Perhaps we should be storing uncompressed size instead?

>
> Is the patch okay now?
>

I would have preferred it if the isCompressed() and related stuff were 
in a separate patch - the rest of the stuff looks ok to me.

Cheers,
Omair