[RFC][Icedtea-web]: Changed how cache works.

[Andrew Su]

----- Original Message -----
> From: "Omair Majid" <omajid at redhat.com>
> To: "Andrew Su" <asu at redhat.com>
> Cc: "Denis Lila" <dlila at redhat.com>, "IcedTea" <distro-pkg-dev at openjdk.java.net>
> Sent: Monday, April 18, 2011 3:23:43 PM
> Subject: Re: [RFC][Icedtea-web]: Changed how cache works.
> On 04/18/2011 03:06 PM, Andrew Su wrote:
> >>
> >> Are the markCompressed/isCompressed methods used anywhere? If not,
> >> could you please make that a separate patch?
> >
> > Yes, I've added the use of isCompressed in CacheEntry.isCached().
> > Reason being that if the item was extracted, the content-length
> > reported
> > by the connection would differ from actual file size, thus forcing
> > it to
> > download without actually checking the modified time.
> >
> 
> That is a problem, but it seems orthogonal to the rest of the patch. I
> am not sure simply ignoring the content-length for compressed files is
> the best thing to do. We wont be able to detect changes in file size.
> Perhaps we should be storing uncompressed size instead?

We can discuss a more on this after this gets in.

> 
> >
> > Is the patch okay now?
> >
> 
> I would have preferred it if the isCompressed() and related stuff were
> in a separate patch - the rest of the stuff looks ok to me.

Ok to push after removing the checks for compression?

Cheers,
 Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20110418_cache_vXX2.patch
Type: text/x-patch
Size: 31185 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110418/3f15cdc3/20110418_cache_vXX2.patch