[RFC][Icedtea-Web]: Enforce cache size limit.

[Denis Lila]

Can you replace this:

> -                    String rStr = value.substring(cacheDir.length());
> +                    String rStr = file.getPath().substring(cacheDir.length());
>                      rStr = cacheDir + rStr.substring(0, rStr.indexOf(File.separatorChar, 1));
> +                    long len = file.length();

with

String rStr = cacheDir + File.separatorChar + CacheLRUWrapper.getIdForCacheFile(value);

We already have the id extraction logic encapsulated in a function.
There's no need to re-implement it in here (but this require some
visibility changes. Maybe move getIdForCacheFile to CacheUtil?).


> +                        curSize += len;
>                          keep.add(value.substring(rStr.length()));
>                          keep.add(rStr); // We can just use the same map, since these two things are disjoint with each other.

Can you please introduce a new Set<String>? I understand that
they're disjoint, but it's still clearer and closer to what we
want to have two sets: one for use in removeUntracked, and
one for use in cleanCache.
That way correctness would be obvious. This way the reader
has to think about tricky corner cases.

Thank you,
Denis.

----- Original Message -----
> Hello,
> 
> This patch will ensure the cache size will remain at most the size
> specified in the user's deployment's properties file.
> 
> This is executed only at jvm shutdown of the plugin and/or javaws.
> 
> Questions? Comments? Concerns?
> 
> Regards,
> Andrew