IcedTea7 build failed for 2cd959df7e7a

[Omair Majid]

On 04/20/2011 10:22 AM, Dr Andrew John Hughes wrote:
> On 09:02 Wed 20 Apr     , Mark Wielaard wrote:
>> On Wed, 2011-04-20 at 02:56 +0100, Dr Andrew John Hughes wrote:
>>> On 17:37 Mon 18 Apr     , Mark Wielaard wrote:
>>>> The current IcedTea build fails.
>>>>
>>> snip...
>>>
>>>> Checking patches/cacao/launcher.patch
>>>> 1 out of 3 hunks FAILED -- saving rejects to file openjdk/jdk/src/share/bin/java.c.rej
>>>> ERROR patch patches/cacao/launcher.patch FAILED!
>>>> WARNING make clean-patch before retrying a fix
>>>> make: *** [stamps/patch.stamp] Error 2
>>>
>>> I'm not seeing this.  Is this because these buildbots enable CACAO?
>>
>> Yes it uses:
>>
>> (cd $ICEDTEA_DIR&&  ./autogen.sh \
>>          &&  cd $ICEDTEA_BUILD_DIR \
>>          &&  $ICEDTEA_DIR/configure \
>>                  --enable-nss \
>>                  --with-additional-vms=cacao,shark \
>>          &&  make VERBOSE=true) 2>&1 | tee $BUILD_LOG_FILE
>> See http://icedtea.classpath.org/hg/buildbot/file/tip/icedtea/build.sh
>>
>> Other builders also seem to fail currently. See e.g.
>> http://builder.classpath.org/icedtea/buildbot/builders/icedtea7-squeeze-x86_64-full/builds/10
>> which has the full configure step in its logs (step 4).
>>
>> Cheers,
>>
>> Mark
>>
>
> Yes, well I haven't tested CACAO in a while.   It's not high on my list of priorities.
> Getting the basic build working tends to be more important :-)

I dug into the cacao errors, and it turns out there are some real 
issues. The attached patch updates the cacao patches to apply, but it is 
not sufficient. Cacao relies on hpi which was removed in OpenJDK7. Some 
of the hpi methods are trivial (Close(int) becomes ::close(int)), but 
others (like NativePath(char*)) are non-trivial. I suppose I can copy 
over the implementation of those methods from hotspot, but I would 
prefer to avoid doing this as an icedtea patch. Perhaps upstream cacao 
should be taking care of this.

Cheers,
Omair
-------------- next part --------------
A non-text attachment was scrubbed...
Name: icedtea7-make-cacao-patches-apply.patch
Type: text/x-patch
Size: 1169 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110420/b0b8e90c/icedtea7-make-cacao-patches-apply.patch