IcedTea7 build failed for 2cd959df7e7a

[Dr Andrew John Hughes]

On 14:19 Wed 20 Apr     , Omair Majid wrote:
> > Yes, well I haven't tested CACAO in a while.   It's not high on my list of priorities.
> > Getting the basic build working tends to be more important :-)
> 
> I dug into the cacao errors, and it turns out there are some real 
> issues. The attached patch updates the cacao patches to apply, but it is 
> not sufficient. Cacao relies on hpi which was removed in OpenJDK7. Some 
> of the hpi methods are trivial (Close(int) becomes ::close(int)), but 
> others (like NativePath(char*)) are non-trivial. I suppose I can copy 
> over the implementation of those methods from hotspot, but I would 
> prefer to avoid doing this as an icedtea patch. Perhaps upstream cacao 
> should be taking care of this.
> 

I was aware there might be a HPI issue.  Feel free to apply the patch below (with a ChangeLog).
I think the CACAO developers need to sort the bigger issue if they want to retain support in
IcedTea7.

> Cheers,
> Omair

> diff -r 8f9c35e54e17 patches/cacao/ignore-tests.patch
> --- a/patches/cacao/ignore-tests.patch	Tue Apr 19 15:35:23 2011 +0100
> +++ b/patches/cacao/ignore-tests.patch	Wed Apr 20 12:22:11 2011 -0400
> @@ -2,7 +2,7 @@
>  --- openjdk.orig/jdk/test/java/util/concurrent/BlockingQueue/ProducerConsumerLoops.java	2010-05-10 15:04:14.000000000 +0100
>  +++ openjdk/jdk/test/java/util/concurrent/BlockingQueue/ProducerConsumerLoops.java	2010-05-10 23:42:41.000000000 +0100
>  @@ -37,6 +37,7 @@
> -  * @compile ProducerConsumerLoops.java
> +  * @compile -source 1.5 ProducerConsumerLoops.java
>    * @run main/timeout=3600 ProducerConsumerLoops
>    * @summary  multiple producers and consumers using blocking queues
>  + * @ignore cacao test hog, ignore for the sake of buildds
> diff -r 8f9c35e54e17 patches/cacao/launcher.patch
> --- a/patches/cacao/launcher.patch	Tue Apr 19 15:35:23 2011 +0100
> +++ b/patches/cacao/launcher.patch	Wed Apr 20 12:22:11 2011 -0400
> @@ -30,7 +30,7 @@
>   
>         args.argc = argc;
>  @@ -1931,7 +1935,17 @@
> -       args.classname = classname;
> +       args.what = what;
>         args.ifn = *ifn;
>   
>  -      rslt = ContinueInNewThread0(JavaMain, threadStackSize, (void*)&args);


-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37