RFC: drop patches/ssl.patch

[Dr Andrew John Hughes]

On 17:31 Tue 26 Apr     , Omair Majid wrote:
> Hi,
> 
> The attached patch drops patches/ssl.patch from icedtea6. ssl.patch 
> contains no functional changes. From what I can see it casts some classes:
> 
> TlsMasterSecretParameterSpec is cast to AlgorithmParameterSpec
> TlsRsaPremasterSecretParameterSpec is cast to AlgorithmParameterSpec
> 
> The class definitions are:
> 
> jdk/src/share/classes/sun/security/internal/spec/TlsMasterSecretParameterSpec.java:
> 
> public class TlsMasterSecretParameterSpec implements AlgorithmParameterSpec
> 
> jdk/src/share/classes/sun/security/internal/spec/TlsRsaPremasterSecretParameterSpec.java:
> 
> public class TlsRsaPremasterSecretParameterSpec implements 
> AlgorithmParameterSpec
> 
> This makes the patch look quite redundant. Should I go ahead and drop 
> the patch?
> 
> Thanks,
> Omair

Have you tested this with a full build, i.e. not with --disable-bootstrap which I know is
how you tend to build?

I've already dropped it from 7.  I couldn't find any record of why it was added (pre-1.0
if I recall correctly) and I think it was probably down to when we were using GNU Crypto
to provide cryptography, before Sun released theirs as part of OpenJDK.
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37