RFC: drop patches/ssl.patch

[Omair Majid]

On 04/27/2011 10:50 AM, Dr Andrew John Hughes wrote:
> On 17:31 Tue 26 Apr     , Omair Majid wrote:
>> >  Hi,
>> >
>> >  The attached patch drops patches/ssl.patch from icedtea6. ssl.patch
>> >  contains no functional changes. From what I can see it casts some classes:
>> >
>> >  TlsMasterSecretParameterSpec is cast to AlgorithmParameterSpec
>> >  TlsRsaPremasterSecretParameterSpec is cast to AlgorithmParameterSpec
>> >
>> >  The class definitions are:
>> >
>> >  jdk/src/share/classes/sun/security/internal/spec/TlsMasterSecretParameterSpec.java:
>> >
>> >  public class TlsMasterSecretParameterSpec implements AlgorithmParameterSpec
>> >
>> >  jdk/src/share/classes/sun/security/internal/spec/TlsRsaPremasterSecretParameterSpec.java:
>> >
>> >  public class TlsRsaPremasterSecretParameterSpec implements
>> >  AlgorithmParameterSpec
>> >
>> >  This makes the patch look quite redundant. Should I go ahead and drop
>> >  the patch?
>> >
>> >  Thanks,
>> >  Omair
> Have you tested this with a full build, i.e. not with --disable-bootstrap which I know is
> how you tend to build?
>

Yes. In fact, (after the screw-up last week) I am now building 
icedtea{6,7} using just ./configure. I will build it again before I push.

> I've already dropped it from 7.

Yes, I saw that it was missing. I was trying to find out if I should add 
it to icedtea7 or drop it even from icedtea6.

> I couldn't find any record of why it was added (pre-1.0
> if I recall correctly) and I think it was probably down to when we were using GNU Crypto
> to provide cryptography, before Sun released theirs as part of OpenJDK.

The icedtea6 changeset a51ee3008713 indicates that it was added when 
openjdk6 started providing crypto. But you are more familiar with the 
history than I am.

Cheers,
Omair