RFC: Mark stack as non-executable

[Dr Andrew John Hughes]

On 10:49 Wed 27 Apr     , Omair Majid wrote:
> Hi,
> 
> This patch for the icedtea7 forest (hotspot repo), ported from IcedTea6, 
> marks libjvm.so's stack as non-executable.
> 
> This patch should really be pushed upstream, but it was originally 
> written by Kees Cook who is not on the list of SCA signatories [1].
> 
> Any comments?
> 
> Thanks,
> Omair
> 
> [1] http://sca.java.net/CA_signatories.htm

I thought there was some effort to get it upstream.  Have you checked the
archives?

Ok for the IcedTea7 forest: http://hg.openjdk.java.net/icedtea/jdk7/hotspot

> diff -r ef8632d52263 src/os_cpu/linux_x86/vm/linux_x86_32.s
> --- a/src/os_cpu/linux_x86/vm/linux_x86_32.s	Wed Apr 20 04:38:06 2011 +0100
> +++ b/src/os_cpu/linux_x86/vm/linux_x86_32.s	Wed Apr 27 10:46:17 2011 -0400
> @@ -666,3 +666,4 @@
>          fistpll   (%eax)
>          ret
>  
> +.section        .note.GNU-stack, "", @progbits
> diff -r ef8632d52263 src/os_cpu/linux_x86/vm/linux_x86_64.s
> --- a/src/os_cpu/linux_x86/vm/linux_x86_64.s	Wed Apr 20 04:38:06 2011 +0100
> +++ b/src/os_cpu/linux_x86/vm/linux_x86_64.s	Wed Apr 27 10:46:17 2011 -0400
> @@ -400,3 +400,4 @@
>          addq     $4,%rdx
>          jg       4b
>          ret
> +.section        .note.GNU-stack, "", @progbits


-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37