[icedtea-web] RFC: Minor buildfix for 1.0

[Xerxes Rånby]

On 2011-08-05 11:06, Mark Wielaard wrote:
> Hi,
>
> On Fri, 2011-08-05 at 02:47 +0100, Dr Andrew John Hughes wrote:
>> On 15:30 Thu 04 Aug     , Deepak Bhole wrote:
>>> Just tried to do a clean 1.0 build and noticed that it failed. Not sure how
>>> this slipped before :/
>>
>> That's worrying.
>
> What is even more worrying is that the buildbot also didn't catch this
> according to http://builder.classpath.org/icedtea/buildbot/waterfall
> they are all greeen. (scroll to the far right - yes, I will split the
> buildbot one of these days so the build overviews are a little smaller).
> Was this a 1.0 only change that never made it to trunk/tip that buildbot
> is building?

The buildbots needs to get updated to actually test all the release branches.

>
> BTW both ARM (v5tel and v7l) icedtea-web builds have some test failures
> (those orange blobs - click on logs to see which exactly), they might be
> ARM specific, but maybe someone could take a look if they somehow are
> general failures that just happen to trigger on ARM.

The x86_64 builder happens to not run all tests because "junit" are not installed.
as can be detected in the x86_64 configure log:
checking for junit jar... no
The missing junit makes the x86_builder only test the first 193 jrunscript icedtea-web 
tests, the remaining 48 junit tests then unfortunally gets skipped.

The two ARM builders do have junit installed:
first all the 193 jrunscripts icedtea-web test pass on the ARM builders and then
44 junit tests pass
the 4 failing junit tests are:
FAILED: testCommentInAttributes(net.sourceforge.jnlp.ParserCornerCases) expected:<[<!-- 
something -->]> but was:<[1.0+]>
FAILED: testMalformedArguments(net.sourceforge.jnlp.ParserMalformedXml) Invalid XML 
document syntax.
FAILED: testTagNotClosed(net.sourceforge.jnlp.ParserMalformedXml) Invalid XML document syntax.
FAILED: testUnquotedAttributes(net.sourceforge.jnlp.ParserMalformedXml) Invalid XML 
document syntax.

Mark can you install junit on the x86_64 builder?

>
> Cheers,
>
> Mark

Cheers
Xerxes