[icedtea-web] RFC: Minor buildfix for 1.0

[Mark Wielaard]

On Fri, 2011-08-05 at 11:49 +0200, Xerxes Rånby wrote:
> On 2011-08-05 11:06, Mark Wielaard wrote:
> > BTW both ARM (v5tel and v7l) icedtea-web builds have some test failures
> > (those orange blobs - click on logs to see which exactly), they might be
> > ARM specific, but maybe someone could take a look if they somehow are
> > general failures that just happen to trigger on ARM.
> 
> The x86_64 builder happens to not run all tests because "junit" are not installed.
> as can be detected in the x86_64 configure log:
> checking for junit jar... no
> The missing junit makes the x86_builder only test the first 193 jrunscript icedtea-web 
> tests, the remaining 48 junit tests then unfortunally gets skipped.
> 
> The two ARM builders do have junit installed:
> first all the 193 jrunscripts icedtea-web test pass on the ARM builders and then
> 44 junit tests pass
> the 4 failing junit tests are:
> FAILED: testCommentInAttributes(net.sourceforge.jnlp.ParserCornerCases) expected:<[<!-- 
> something -->]> but was:<[1.0+]>
> FAILED: testMalformedArguments(net.sourceforge.jnlp.ParserMalformedXml) Invalid XML 
> document syntax.
> FAILED: testTagNotClosed(net.sourceforge.jnlp.ParserMalformedXml) Invalid XML document syntax.
> FAILED: testUnquotedAttributes(net.sourceforge.jnlp.ParserMalformedXml) Invalid XML 
> document syntax.
> 
> Mark can you install junit on the x86_64 builder?

Doh, I hadn't noticed that. I have installed junit 3.8.2-4 on it now.
Lets see what the next build says.

BTW. Do we really want to use junit? I always thought that was somewhat
problematic because it has an odd (GPL-incompatible) license (the CPL).
Which seems to prevent redistribution of the larger junit (CPL) + tests
(GPL) because of the license conflict. Or does the special GPL-exception
kick in here?

Cheers,

Mark