Revert wars, make dist, etc.

Andrew Haley aph at redhat.com
Wed Dec 21 02:27:00 PST 2011


There's a continuing problem with the way that jtreg is handled in
IcedTea.

The core problem seems to be that some parts of IcedTea need absolute
paths, and some need relative paths.  "make dist", in particular,
needs a relative path.  However, jtreg -othervm needs an *absolute*
path to the -exclude file.  So, it is clear that some uses need
JTREG_SRCS to be absolute, some need it to be relative.  We need
both, in other words.  It can't be one or the other.

doko made a change in

	Fix running jamvm jdk tests when configured with a separate relative
	build dir

	2011-12-08 Matthias Klose <doko at ubuntu.com>

	 * Makefile.am (JTREG_SRCS): Use abs_top_srcdir.

which made JTREG_SRCS absolute.  This patch was not discussed.  I
complained that it broke "make dist", so doko pushed another patch

	Fix make dist, not using any prefixes in EXTRA_DIST

	2011-12-16 Matthias Klose <doko at ubuntu.com>

	 * Makefile.am (JTREG_SRCS, REWRITER_SRCS, EXTRA_DIST): Don't
	use any prefixes. (stamps/jtreg.stamp, check-jdk):
	Use JTREG_SRCS with srcdir prefix. (stamps/rewriter.stamp):
	Use REWRITER_SRCS with srcdir prefix.

which fixed that.  However, this patch was not discussed.

Andrew Hughes backed this patch out, pointing out that it reverts a
number of earlier changes.  So, jtreg --othervm is broken, again.

jtreg needs an absolute path.  Lets try and have a proper discussion
about how to do it, with no more commits or reversions until we've
decided together what to do.

Andrew.



More information about the distro-pkg-dev mailing list