[icedtea-web] RFC: show more information about certificates when verifying nested jars

Deepak Bhole dbhole at redhat.com
Tue Feb 1 18:48:36 PST 2011


* Deepak Bhole <dbhole at redhat.com> [2011-02-01 20:09]:
> * Omair Majid <omajid at redhat.com> [2011-02-01 20:02]:
> > Hi,
> > 
> > The attached patch fixes a bug in icedtea-web where clicking on the
> > "more information" button on a security prompt involving nested
> > jars, throws an exception.
> > 
> > Ok to commit?
> > 
> 
> Yep, looks good to me. Okay for HEAD, 1.0, icedtea6-1.7, icedtea6-1.8
> and icedtea6-1.9 (which are also affected).
> 

Just noticed that this commit breaks the build. I didn't notice it the
first time with a clean build because it built with the JarSigner 
from the previous netx.jar in the JDK. A rebuild on top of that fails.

A grep in the icedtea-web dir for JarRunner shows nothing is using it.
Attached patch removes the file which makes icedtea-web buildable again. 

Okay for commit?

Cheers,
Deepak

-------------- next part --------------
diff -r 4b7fe3bb41fa ChangeLog
--- a/ChangeLog	Tue Feb 01 21:11:11 2011 -0500
+++ b/ChangeLog	Tue Feb 01 21:44:27 2011 -0500
@@ -1,3 +1,7 @@
+2011-02-01  Deepak Bhole <dbhole at redhat.com>
+
+	* netx/net/sourceforge/jnlp/tools/JarRunner.java: Removed unused file.
+
 2011-02-01  Omair Majid  <omajid at redhat.com>
 
 	* netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java
diff -r 4b7fe3bb41fa netx/net/sourceforge/jnlp/tools/JarRunner.java
--- a/netx/net/sourceforge/jnlp/tools/JarRunner.java	Tue Feb 01 21:11:11 2011 -0500
+++ /dev/null	Thu Jan 01 00:00:00 1970 +0000
@@ -1,14 +0,0 @@
-package net.sourceforge.jnlp.tools;
-
-import net.sourceforge.jnlp.tools.JarSigner;
-
-public class JarRunner {
-
-    public static void main(String[] args) throws Exception {
-
-        //JarSigner.main(args);
-        JarSigner js = new JarSigner();
-        js.verifyJar(args[0]);
-    }
-
-}


More information about the distro-pkg-dev mailing list