[icedtea-web] RFC: show more information about certificates when verifying nested jars

Omair Majid omajid at redhat.com
Tue Feb 1 18:53:47 PST 2011


On 02/01/2011 09:48 PM, Deepak Bhole wrote:
> * Deepak Bhole<dbhole at redhat.com>  [2011-02-01 20:09]:
>> * Omair Majid<omajid at redhat.com>  [2011-02-01 20:02]:
>>> Hi,
>>>
>>> The attached patch fixes a bug in icedtea-web where clicking on the
>>> "more information" button on a security prompt involving nested
>>> jars, throws an exception.
>>>
>>> Ok to commit?
>>>
>>
>> Yep, looks good to me. Okay for HEAD, 1.0, icedtea6-1.7, icedtea6-1.8
>> and icedtea6-1.9 (which are also affected).
>>
>
> Just noticed that this commit breaks the build. I didn't notice it the
> first time with a clean build because it built with the JarSigner
> from the previous netx.jar in the JDK. A rebuild on top of that fails.
>

Sorry, my fault. I only tested the patch with icedtea-web HEAD, which 
(unlike icedtea-web 1.0) does not have JarRunner.

> A grep in the icedtea-web dir for JarRunner shows nothing is using it.
> Attached patch removes the file which makes icedtea-web buildable again.
>
> Okay for commit?
>

As a partial backport of 
http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-December/011325.html, 
this looks fine to me.

Please go ahead and commit.

Cheers,
Omair



More information about the distro-pkg-dev mailing list