Reviewer needed - fix for Re: Strange behaviour during javaws -about
Dr Andrew John Hughes
ahughes at redhat.com
Wed Feb 23 09:51:12 PST 2011
What is the motivation for this change? Assuming it still runs without
all-permissions, the change looks fine.
Please do the Makefile.am change in a separate patch; it's easier to
debug and revert things when issues are separate.
On 18:17 Wed 23 Feb , Jiri Vanek wrote:
> # HG changeset patch
> # User Jiri Vanek <jvanek at redhat.com>
> # Date 1298481249 -3600
> # Node ID 3068613e852576e9820a3498d9ef305cbecde002
> # Parent f14bd72dbb29dd48c0bcf388f5e7fad88b044b76
> javaws -about is no longer loaded remotely, have no permissions, and do
> not cause hanging of jvm after closing about window.
>
> diff -r f14bd72dbb29 -r 3068613e8525 ChangeLog
> --- a/ChangeLog Tue Feb 22 19:15:05 2011 -0500
> +++ b/ChangeLog Wed Feb 23 18:14:09 2011 +0100
> @@ -1,3 +1,9 @@
> +2011-02-23 Jiri Vanek <jvanek at redhat.com>
> +
> + * Makefile.am : fixed '/' typo in JRE variable
I think this should be a separate patch. Completely different issue.
> + * about.jnlp : about.jar is loaded from localhost and without
> security permissions, fixed #rhbz677334
> +
> +
> 2011-02-22 Omair Majid <omajid at redhat.com>
> Mark Greenwood <mark at dcs.shef.ac.uk>
>
> diff -r f14bd72dbb29 -r 3068613e8525 Makefile.am
> --- a/Makefile.am Tue Feb 22 19:15:05 2011 -0500
> +++ b/Makefile.am Wed Feb 23 18:14:09 2011 +0100
> @@ -17,7 +17,7 @@
> IT_CLASS_TARGET_VERSION=6
> IT_JAVACFLAGS=$(IT_JAVAC_SETTINGS) -source
> $(IT_LANGUAGE_SOURCE_VERSION) -target $(IT_CLASS_TARGET_VERSION)
>
> -JRE='"$(SYSTEM_JDK_DIR)jre"'
> +JRE='"$(SYSTEM_JDK_DIR)/jre"'
>
> LAUNCHER_BOOTCLASSPATH="-J-Xbootclasspath/a:$(DESTDIR)$(datadir)/$(PACKAGE_NAME)/netx.jar"
>
> PLUGIN_BOOTCLASSPATH='"-Xbootclasspath/a:$(DESTDIR)$(datadir)/$(PACKAGE_NAME)/netx.jar:$(DESTDIR)$(datadir)/$(PACKAGE_NAME)/plugin.jar"'
>
> diff -r f14bd72dbb29 -r 3068613e8525
> netx/net/sourceforge/jnlp/resources/about.jnlp
> --- a/netx/net/sourceforge/jnlp/resources/about.jnlp Tue Feb 22 19:15:05
> 2011 -0500
> +++ b/netx/net/sourceforge/jnlp/resources/about.jnlp Wed Feb 23 18:14:09
> 2011 +0100
> @@ -1,5 +1,5 @@
> <?xml version="1.0" encoding="utf-8"?>
> -<jnlp spec="1.0" href="about.jnlp"
> codebase="http://icedtea.classpath.org/netx/">
> +<jnlp spec="1.0" href="about.jnlp" codebase=".">
> <information>
> <title>About window for NetX</title>
> <vendor>NetX</vendor>
> @@ -12,7 +12,7 @@
> <jar href="about.jar"/>
> </resources>
> <security>
> - <all-permissions/>
> +
> </security>
> <application-desc main-class="net.sourceforge.jnlp.about.Main">
> </application-desc>
--
Andrew :)
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37
More information about the distro-pkg-dev
mailing list