Reviewer needed - fix for Re: Strange behaviour during javaws -about
Omair Majid
omajid at redhat.com
Wed Feb 23 15:36:43 PST 2011
On 02/23/2011 12:51 PM, Dr Andrew John Hughes wrote:
> What is the motivation for this change? Assuming it still runs without
> all-permissions, the change looks fine.
>
From my very limited testing, it doesnt :(
With IcedTea-Web 1.0
$ ./javaws -about
netx v0.5 - (C)2001-2003 Jon A. Maxwell (jmaxwell at users.sourceforge.net)
Launching about window...
net.sourceforge.jnlp.LaunchException: Fatal: Launch Error: Could not
launch JNLP file.
[snip]
Caused by: java.security.AccessControlException: access denied
(java.lang.RuntimePermission
accessClassInPackage.net.sourceforge.jnlp.about)
[snip]
With IcedTea-Web HEAD before the change to non-JDK dirs:
$ ./javaws -about
icedtea-web 1.1pre+rd7fee305bd4f
Launching about window...
net.sourceforge.jnlp.LaunchException: Fatal: Launch Error: Could not
launch JNLP file.
[snip]
Caused by: java.security.AccessControlException: access denied
(java.lang.RuntimePermission
accessClassInPackage.net.sourceforge.jnlp.about)
[snip]
(As an aside, I wonder why the hg revision shown does not correspond to
the version used to build).
With IcedTea-Web HEAD
$ bin/javaws -about
icedtea-web 1.1pre+rd7fee305bd4f
Launching about window...
JAR
jar:file:/home/omajid/code/icedtea-web-image/share/icedtea-web/netx.jar!/net/sourceforge/jnlp/resources/about.jar
not found. Continuing.
net.sourceforge.jnlp.LaunchException: Fatal: Launch Error: Could not
launch JNLP file.
[snip]
> Please do the Makefile.am change in a separate patch; it's easier to
> debug and revert things when issues are separate.
>
I posted the Makefile.am patch right around the same time Jiri posted
this one; Deepak approved it and I have pushed it to HEAD already.
Omair
More information about the distro-pkg-dev
mailing list