/hg/icedtea: New configure option --with-llvm-config

[Mark Wielaard]

On Fri, January 21, 2011 21:04, Dr Andrew John Hughes wrote:
> On 19:29 Fri 21 Jan     , mjw at icedtea.classpath.org wrote:
>> http://icedtea.classpath.org/hg/icedtea?cmd=changeset;node=da307731d8d2
>> author: doko at ubuntu.com
>> date: Thu Oct 14 13:25:44 2010 +0200
>>
>> 	New configure option --with-llvm-config
>>
>> 	2010-10-14 Matthias Klose <doko at ubuntu.com>
>>
>> 	 * configure.ac: New option --with-llvm-config.
>> 	        * INSTALL: Document it.
>
> This will error out if --without-llvm-config is specified
> (withval=no), which I don't think is the right behaviour.  Worse, if
> --with-llvm-config is specified, withval will be yes and 'which yes'
> will return /bin/yes, setting LLVM_CONFIG to this value.
>
> Please add cases to handle these values.

To be honest, both cases seem somewhat far fetched.
And even if people would try such things configure will
indicate that by just failing with an error message that llvm-config
is setup wrongly when they us it (when shark is enabled).

But I assume you would like something like this?

diff -r da307731d8d2 configure.ac
--- a/configure.ac	Thu Oct 14 13:25:44 2010 +0200
+++ b/configure.ac	Fri Jan 21 21:48:07 2011 +0100
@@ -395,7 +395,7 @@
             [AS_HELP_STRING([--with-llvm-config],
                             [llvm-config binary (default is llvm-config)])],
             [
-              if test "x${withval}" != x; then
+              if test "x${withval}" != x && test "x${withval}" != xyes &&
test "x${withval}" != xno; then
 	        if which ${withval} >/dev/null 2>&1 && ${withval} --version
>/dev/null 2>&1; then
 		  LLVM_CONFIG=${withval}
 		else

Cheers,

Mark