/hg/icedtea: New configure option --with-llvm-config

[Dr Andrew John Hughes]

On 21:46 Fri 21 Jan     , Mark Wielaard wrote:
> On Fri, January 21, 2011 21:04, Dr Andrew John Hughes wrote:
> > On 19:29 Fri 21 Jan     , mjw at icedtea.classpath.org wrote:
> >> http://icedtea.classpath.org/hg/icedtea?cmd=changeset;node=da307731d8d2
> >> author: doko at ubuntu.com
> >> date: Thu Oct 14 13:25:44 2010 +0200
> >>
> >> 	New configure option --with-llvm-config
> >>
> >> 	2010-10-14 Matthias Klose <doko at ubuntu.com>
> >>
> >> 	 * configure.ac: New option --with-llvm-config.
> >> 	        * INSTALL: Document it.
> >
> > This will error out if --without-llvm-config is specified
> > (withval=no), which I don't think is the right behaviour.  Worse, if
> > --with-llvm-config is specified, withval will be yes and 'which yes'
> > will return /bin/yes, setting LLVM_CONFIG to this value.
> >
> > Please add cases to handle these values.
> 
> To be honest, both cases seem somewhat far fetched.

Maybe, but undoubtably someone will do it.  I know it's been reported in the past.

> And even if people would try such things configure will
> indicate that by just failing with an error message that llvm-config
> is setup wrongly when they us it (when shark is enabled).
> 

Only for the no case.  yes would succeed as I said.

> But I assume you would like something like this?
> 

Yeah, that's fine.  Sorry, I didn't realise before that this was a forwardport
(and thus doko's bad, not yours).  The same needs fixing in IcedTea6.

> diff -r da307731d8d2 configure.ac
> --- a/configure.ac	Thu Oct 14 13:25:44 2010 +0200
> +++ b/configure.ac	Fri Jan 21 21:48:07 2011 +0100
> @@ -395,7 +395,7 @@
>              [AS_HELP_STRING([--with-llvm-config],
>                              [llvm-config binary (default is llvm-config)])],
>              [
> -              if test "x${withval}" != x; then
> +              if test "x${withval}" != x && test "x${withval}" != xyes &&
> test "x${withval}" != xno; then
>  	        if which ${withval} >/dev/null 2>&1 && ${withval} --version
> >/dev/null 2>&1; then
>  		  LLVM_CONFIG=${withval}
>  		else
> 
> Cheers,
> 
> Mark
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8