[icedtea-web] RFC: remove default.jnlp

[Omair Majid]

On 01/24/2011 06:07 PM, Dr Andrew John Hughes wrote:
> On 16:55 Mon 24 Jan     , Omair Majid wrote:
>> On 01/24/2011 04:25 PM, Dr Andrew John Hughes wrote:
>>> On 15:58 Mon 24 Jan     , Omair Majid wrote:
>>>> The attached patch removes default.jnlp from icedtea-web. This seems to
>>>> be a copy of about.jnlp (About.jnlp gets invoked on javaws -about), but
>>>> is completely unused. Ok to remove?
>>>>
>>>
>>> Does the name have any special significance?  Have you checked it isn't loaded
>>> or something if you don't specify a JNLP file?
>>>
>>
>> That's what I thought at first. Running javaws with no-args prints out
>> the help message. I grepped the entire source and default.jnlp does not
>> appear anywhere. Digging into it's history, here is what I found:
>> icedtea6 changeset bd6babe8221f [1], which introduced the about.jnlp
>> file, also changed the uses of default.jnlp to about.jnlp (the relevant
>> changes are in rt/net/sourceforge/jnlp/runtime/Boot.java). The changeset
>> should also have deleted default.jnlp.
>>
>
> Ok, great, we can delete it then.
>

Thanks for looking it over; I have pushed the changeset.

>>> On the subject of about.jnlp, can someone please update it so recent work is credited?
>>> It currently gives all credit to Jon Maxwell and Joshua Sumali.
>>>
>>
>> I can take a look at it. Updating the in-repository copy should not be
>> too hard, but about.jnlp is actually run from the classpath servers, and
>> I do not have permission to edit icedtea.classpath.org:/var/www/netx.
>>
>
> It seems I do, so I can update the server copy once the fix is in IcedTea-Web.
>

I have attached a patch to update the list in the about.jnlp as well as 
add Jon to AUTHORS.

I would also like to update the release notes (in notes.html) and the 
versions used, but that's another patch.

Ok to commit?

Cheers,
Omair
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-people-to-about.patch
Type: text/x-patch
Size: 1647 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110125/7e4d67a1/add-people-to-about.patch