[icedtea-web] RFC: remove default.jnlp

[Dr Andrew John Hughes]

On 10:34 Tue 25 Jan     , Omair Majid wrote:
> On 01/24/2011 06:07 PM, Dr Andrew John Hughes wrote:
> > On 16:55 Mon 24 Jan     , Omair Majid wrote:
> >> On 01/24/2011 04:25 PM, Dr Andrew John Hughes wrote:
> >>> On 15:58 Mon 24 Jan     , Omair Majid wrote:
> >>>> The attached patch removes default.jnlp from icedtea-web. This seems to
> >>>> be a copy of about.jnlp (About.jnlp gets invoked on javaws -about), but
> >>>> is completely unused. Ok to remove?
> >>>>
> >>>
> >>> Does the name have any special significance?  Have you checked it isn't loaded
> >>> or something if you don't specify a JNLP file?
> >>>
> >>
> >> That's what I thought at first. Running javaws with no-args prints out
> >> the help message. I grepped the entire source and default.jnlp does not
> >> appear anywhere. Digging into it's history, here is what I found:
> >> icedtea6 changeset bd6babe8221f [1], which introduced the about.jnlp
> >> file, also changed the uses of default.jnlp to about.jnlp (the relevant
> >> changes are in rt/net/sourceforge/jnlp/runtime/Boot.java). The changeset
> >> should also have deleted default.jnlp.
> >>
> >
> > Ok, great, we can delete it then.
> >
> 
> Thanks for looking it over; I have pushed the changeset.
> 
> >>> On the subject of about.jnlp, can someone please update it so recent work is credited?
> >>> It currently gives all credit to Jon Maxwell and Joshua Sumali.
> >>>
> >>
> >> I can take a look at it. Updating the in-repository copy should not be
> >> too hard, but about.jnlp is actually run from the classpath servers, and
> >> I do not have permission to edit icedtea.classpath.org:/var/www/netx.
> >>
> >
> > It seems I do, so I can update the server copy once the fix is in IcedTea-Web.
> >
> 
> I have attached a patch to update the list in the about.jnlp as well as 
> add Jon to AUTHORS.
> 
> I would also like to update the release notes (in notes.html) and the 
> versions used, but that's another patch.
> 
> Ok to commit?
> 
> Cheers,
> Omair

Yes, looks good.

> diff -r 804cd535d907 AUTHORS
> --- a/AUTHORS	Mon Jan 24 10:20:57 2011 -0500
> +++ b/AUTHORS	Mon Jan 24 19:11:19 2011 -0500
> @@ -8,6 +8,7 @@
>  Matthias Klose <doko at ubuntu.com>
>  Francis Kung <fkung at redhat.com>
>  Omair Majid <omajid at redhat.com>
> +Jon A. Maxwell <jmaxwell at users.sourceforge.net>
>  Andrew Su <asu at redhat.com>
>  Joshua Sumali <jsumali at redhat.com>
>  Mark Wielaard <mark at klomp.org>
> diff -r 804cd535d907 extra/net/sourceforge/jnlp/about/resources/notes.html
> --- a/extra/net/sourceforge/jnlp/about/resources/notes.html	Mon Jan 24 10:20:57 2011 -0500
> +++ b/extra/net/sourceforge/jnlp/about/resources/notes.html	Mon Jan 24 19:11:19 2011 -0500
> @@ -21,10 +21,18 @@
>  						<tr>
>  							<td valign="Middle" nowrap="true" align="Justify">
>  								<div align="Center">
> -								<big><b>Jon A. Maxwell</b></big><br>
> -								developer<br>
> -								<big><b>Joshua Sumali</b></big><br>
> -								developer
> +                                <b>Lillian Angel</b> <br>
> +                                <b>Deepak Bhole</b> <br>
> +                                <b>Thomas Fitzsimmons</b> <br>
> +                                <b>Andrew John Hughes</b> <br>
> +                                <b>Matthias Klose </b> <br>
> +                                <b>Francis Kung</b> <br>
> +                                <b>Omair Majid</b> <br>
> +                                <b>Jon A. Maxwell</b> <br>
> +                                <b>Andrew Su</b> <br>
> +                                <b>Joshua Sumali</b> <br>
> +                                <b>Mark Wielaard</b> <br>
> +                                <b>Man Lung Wong</b> <br>
>  								</div>
>  							</td>
>  						</tr>


-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8