[icedtea-web] RFC: pick up name and version from configure

[Dr Andrew John Hughes]

On 16:50 Thu 27 Jan     , Omair Majid wrote:
> On 01/26/2011 07:27 PM, Dr Andrew John Hughes wrote:
> >> On 01/26/2011 02:44 PM, Dr Andrew John Hughes wrote:
> >>> I think it would be much cleaner to produce the manifest using
> >>> autoconf's existing support for this rather than hacking stuff
> >>> into the Makefile.  You need to AC_SUBST FULL_VERSION and then
> >>> add netx.manifest to AC_CONFIG_FILES.  autoconf will do the rest.
> >>> Make sure that the macros that set ICEDTEA_REVISION
> >>> (IT_OBTAIN_HG_REVISIONS) and PKGVERSION (IT_GET_PKGVERSION) are
> >>> run before FULL_VERSION is set.  Something like the attached
> >>> patch should do it.
> >>>
> > The .desktop files are already there (which incidentally should move
> > to this system too).
> >
> 
> The only substitution performed in the desktop-related *.in files
> relates to adding @bindir@/$executable_name in it. The automake manual
> discourages [1] [2] depending on the installation path in the configure
> stage. It instead recommends that snippets be used to generate the
> output file from the .in file during make. This is what we already do.
> Is there a good reason why we should move the desktop files to the
> AC_CONFIG_FILES system? I am sure I am missing something quite obvious here.
> 

Nah, I just thought it might be more maintainable with the sed statements.
But if automake recommends doing it as we do now, it's fine as is.

> Thanks,
> Omair
> 
> [1] 
> http://www.gnu.org/software/autoconf/manual/html_node/Installation-Directory-Variables.html#Installation-Directory-Variables
> [2] 
> http://www.gnu.org/software/autoconf/manual/html_node/Defining-Directories.html#Defining-Directories

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8