[icedtea-web] RFC: pick up name and version from configure

[Omair Majid]

On 01/26/2011 07:27 PM, Dr Andrew John Hughes wrote:
>> On 01/26/2011 02:44 PM, Dr Andrew John Hughes wrote:
>>> I think it would be much cleaner to produce the manifest using
>>> autoconf's existing support for this rather than hacking stuff
>>> into the Makefile.  You need to AC_SUBST FULL_VERSION and then
>>> add netx.manifest to AC_CONFIG_FILES.  autoconf will do the rest.
>>> Make sure that the macros that set ICEDTEA_REVISION
>>> (IT_OBTAIN_HG_REVISIONS) and PKGVERSION (IT_GET_PKGVERSION) are
>>> run before FULL_VERSION is set.  Something like the attached
>>> patch should do it.
>>>
> The .desktop files are already there (which incidentally should move
> to this system too).
>

The only substitution performed in the desktop-related *.in files
relates to adding @bindir@/$executable_name in it. The automake manual
discourages [1] [2] depending on the installation path in the configure
stage. It instead recommends that snippets be used to generate the
output file from the .in file during make. This is what we already do.
Is there a good reason why we should move the desktop files to the
AC_CONFIG_FILES system? I am sure I am missing something quite obvious here.

Thanks,
Omair

[1] 
http://www.gnu.org/software/autoconf/manual/html_node/Installation-Directory-Variables.html#Installation-Directory-Variables
[2] 
http://www.gnu.org/software/autoconf/manual/html_node/Defining-Directories.html#Defining-Directories