[icedtea-web] RFC: pick up name and version from configure

[Omair Majid]

On 01/27/2011 04:56 PM, Dr Andrew John Hughes wrote:
> On 13:11 Thu 27 Jan     , Omair Majid wrote:
>> On 01/26/2011 07:27 PM, Dr Andrew John Hughes wrote:
>>> On 17:51 Wed 26 Jan     , Omair Majid wrote:
>>>> On 01/26/2011 02:44 PM, Dr Andrew John Hughes wrote:
>>>>> On 12:13 Tue 25 Jan     , Omair Majid wrote:
>>>>>> The attached patch gets rid of the hardcoded names and version numbers
>>>>>> in net. It makes netx pick up the right name and version form the
>>>>>> configure script.
>>>>>>
>>>>>
>>>>> I think it would be much cleaner to produce the manifest using autoconf's existing support for this
>>>>> rather than hacking stuff into the Makefile.  You need to AC_SUBST FULL_VERSION and then add
>>>>> netx.manifest to AC_CONFIG_FILES.  autoconf will do the rest.  Make sure that the macros that
>>>>> set ICEDTEA_REVISION (IT_OBTAIN_HG_REVISIONS) and PKGVERSION (IT_GET_PKGVERSION) are run before
>>>>> FULL_VERSION is set.  Something like the attached patch should do it.
>>>>>
>>>>> $ /home/andrew/projects/openjdk/icedtea-web/configure
>>>>> ...
>>>>> checking what version string to use... 1.1pre+r64da2a80df88
>>>>> ...
>>>>> $ cat netx/netx.manifest
>>>>> Implementation-Title: icedtea-web
>>>>> Implementation-Version: 1.1pre+r64da2a80df88
>>>>>
>>>>> $ /home/andrew/projects/openjdk/icedtea-web/configure --with-pkgversion=23
>>>>> ...
>>>>> checking what version string to use... 1.1pre+r64da2a80df88 (23)
>>>>> ...
>>>>> $ cat netx/netx.manifest
>>>>> Implementation-Title: icedtea-web
>>>>> Implementation-Version: 1.1pre+r64da2a80df88 (23)
>>>>>
>>>>
>>>> That's a great idea. Thanks for creating a patch for this too! I only
>>>> have one tiny concern: it creates a new dir named netx under the build
>>>> tree instead of using netx.build. I read through autoconf docs and
>>>> nothing that seems like a fix jumped out at me. Any ideas?
>>>>
>>>
>>> Good point.  I'd just move it to the top-level i.e. netx.manifest instead of
>>> netx/netx.manifest.  The .desktop files are already there (which incidentally
>>> should move to this system too).
>>>
>>
>> Done. I am attaching the updated patch. Ok to commit?
>>
>
> Yes, looks fine.  Please commit.
>

Thanks for the review. I have pushed this as changeset 43c8a57314af.

Cheers,
Omair