[RFC] - extended creation of simple reproducers jars

[Dr Andrew John Hughes]

On 15:15 Tue 19 Jul     , Pavel Tisnovsky wrote:
> Hi Jiri,
> 
> thank you for your work. The patch itself looks good, I'm just curious
> if this approach would work in case of many "simple" tests, for example
> 1000 tests. I mean this line:
> 
> +	  $(BOOT_DIR)/bin/javac -d  $(JNLP_TESTS_DIR)/$$dir/ $$srcFiles ; \
> 
> Maybe it would be good to compile the tests in a program loop (it's
> possible to create for-each loop which can run for files found by find
> ;-) ) but if your solution works, I'm ok with it.
> 

I agree.  Why is this rule using a different style to the main NetX/JavaWS
rules? These proceed as follows:

1.  Build a list into a text file in one rule
2.  Compile/copy in a second rule

One other advantage (other than that outlined by Pavel) is that the list
of files does not have to be rebuilt to recompile/recopy.

> 
> Also ChangeLog entry should be IMHO reworded as it's not understandable
> (at least for me, but as you know I'm not a native speaker ;-)
> 

It's barely understandable, but only just for me.  I'm not sure what is meant
by 'honour[ing] the directory structure'.

> Cheers,
> Pavel
> 
> 
> Jiri Vanek wrote:
> > Hi!
> > This patch removes old compiling of files in src directory (by "*") in
> > simple reproducers by finding .java files (honours also directory
> > structure which previous technique ignored) and also copy all not java
> > files into resulted jar (also ignored in "*" approach)
> > Motivation for this patch are by-jnlp-signed reproducers which can
> > appear soon and I do not want to have special build code for them (==
> > including application.jnlp or template.jnlp files)
> > 
> > 
> > 2011-07-12 Jiri Vanek <jvanek at redhat.com>
> > 
> >     *Makefile.am: (stamps/netx-dist-tests-prepare-reproducers.stamp):
> >     now honour directory structure under srcs in simple reproducer and
> >     copy also not compiled java files into resulted jars from src directory
> > 
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37