[RFC] - extended creation of simple reproducers jars

[Pavel Tisnovsky]

Jiri Vanek wrote:
> On 07/19/2011 03:15 PM, Pavel Tisnovsky wrote:
> Hi!
> Thanx for review:
>> Hi Jiri,
>>
>> thank you for your work. The patch itself looks good, I'm just curious
>> if this approach would work in case of many "simple" tests, for example
>> 1000 tests. I mean this line:
>>
>> +      $(BOOT_DIR)/bin/javac -d  $(JNLP_TESTS_DIR)/$$dir/ $$srcFiles ; \
>>
> 
> This line always compile one single reproducer. They have mostly one or
> two classes and it is nearly unbelievable that single reproducer will
> have more tehn hundrets of files. Commandline have 128KB buffer. It i
> smore then enough for SIMPLE reproducer :D

thanks for the explanation. Then I'm satisfied with it :-)

>> Maybe it would be good to compile the tests in a program loop (it's
>> possible to create for-each loop which can run for files found by find
>> ;-) ) but if your solution works, I'm ok with it.
>>
>>
>> Also ChangeLog entry should be IMHO reworded as it's not understandable
>> (at least for me, but as you know I'm not a native speaker ;-)
>>
>> Cheers,
>> Pavel
>>
>>
>> Jiri Vanek wrote:
>>> Hi!
>>> This patch removes old compiling of files in src directory (by "*") in
>>> simple reproducers by finding .java files (honours also directory
>>> structure which previous technique ignored) and also copy all not java
>>> files into resulted jar (also ignored in "*" approach)
>>> Motivation for this patch are by-jnlp-signed reproducers which can
>>> appear soon and I do not want to have special build code for them (==
>>> including application.jnlp or template.jnlp files)
>>>
>>>
>>> 2011-07-12 Jiri Vanek<jvanek at redhat.com>
>>>
>>>      *Makefile.am: (stamps/netx-dist-tests-prepare-reproducers.stamp):
>>>      now honour directory structure under srcs in simple reproducer and
>>>      copy also not compiled java files into resulted jars from src
>>> directory
>>>
>>
> 
>  2011-07-19 Jiri Vanek<jvanek at redhat.com>
> 
>     *Makefile.am: (stamps/netx-dist-tests-prepare-reproducers.stamp):
>     now are compiled files correctly compiled from directory structure.
>     Also not java files are copied with expected directory structure and
>     jarred together with classes.
> 
> 
> 
> Better? The patch remains same.
> 
> Regards J.
>