Reviewer needed: backport of "6970930: RuleBasedCollator.compare(String, null) throws IAE (should be NPE)" into IcedTea6 HEAD

[Dr Andrew John Hughes]

On 11:04 Tue 26 Jul     , Pavel Tisnovsky wrote:
> Dr Andrew John Hughes wrote:
> > On 14:25 Mon 25 Jul     , Pavel Tisnovsky wrote:
> >> Greetings,
> >>
> >> is it possible to push the backport of fix "6970930:
> >> RuleBasedCollator.compare(String,null) throws IAE (should be NPE)"
> >> into IcedTea6 HEAD please?
> >>
> >> The behaviour of this fix was checked on RHELs.
> >>
> >>
> >> Here's ChangeLog entry:
> >>
> >> 2011-07-25  Pavel Tisnovsky  <ptisnovs at redhat.com>
> >>
> >>         * Makefile.am: added new patch
> >>         * NEWS: updated with backport
> >>         *
> >> patches/openjdk/6970930-RuleBasedCollator_compare_throws_IAE.patch:
> >>         Backport of 6970930.patch.
> >>
> >>
> >>
> >> Can anybody please review this change?
> >>
> >> Thank you in advance,
> >> Pavel
> >>
> > 
> > No.  This changes the behaviour of a standard method.
> 
> Hi Andrew,
> 
> do you mean that the new method behaviour is wrong (IMHO not because
> both exceptions are RuntimeException's subclasses) or that there's a
> problem in changed API in Comparator interface (in *JDK7 doc it's
> explicitly written, that NPE should occurs)?
> 

The latter.  You're changing the behaviour of the method.  However
correct that is, we can't do it in 1.6.

> Pavel

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37