Reviewer needed: backport of "6970930: RuleBasedCollator.compare(String, null) throws IAE (should be NPE)" into IcedTea6 HEAD

[Andrew Haley]

On 07/26/2011 01:36 PM, Dr Andrew John Hughes wrote:
> On 11:04 Tue 26 Jul     , Pavel Tisnovsky wrote:
>> Dr Andrew John Hughes wrote:
>>> On 14:25 Mon 25 Jul     , Pavel Tisnovsky wrote:
>>>> Greetings,
>>>>
>>>> is it possible to push the backport of fix "6970930:
>>>> RuleBasedCollator.compare(String,null) throws IAE (should be NPE)"
>>>> into IcedTea6 HEAD please?
>>>>
>>>> The behaviour of this fix was checked on RHELs.
>>>>
>>>>
>>>> Here's ChangeLog entry:
>>>>
>>>> 2011-07-25  Pavel Tisnovsky  <ptisnovs at redhat.com>
>>>>
>>>>         * Makefile.am: added new patch
>>>>         * NEWS: updated with backport
>>>>         *
>>>> patches/openjdk/6970930-RuleBasedCollator_compare_throws_IAE.patch:
>>>>         Backport of 6970930.patch.
>>>>
>>>>
>>>>
>>>> Can anybody please review this change?
>>>
>>> No.  This changes the behaviour of a standard method.
>>
>> Hi Andrew,
>>
>> do you mean that the new method behaviour is wrong (IMHO not because
>> both exceptions are RuntimeException's subclasses) or that there's a
>> problem in changed API in Comparator interface (in *JDK7 doc it's
>> explicitly written, that NPE should occurs)?
> 
> The latter.  You're changing the behaviour of the method.  However
> correct that is, we can't do it in 1.6.

I think that's true.  However bogus, some program may be catching the
IllegalArgumentException.

Andrew.