[icedtea-web] RFC: fix typo in output of itweb-settings

[Dr Andrew John Hughes]

On 16:38 Mon 28 Feb     , Omair Majid wrote:
> Hi,
> 
> The attached patch fixes a typo in itweb-settings. Instead of the 
> property name, it was actually showing the property value:
> 
> $ itweb-settings set unknown.property.name foo
> Unknown property-name "foo"
> 
> It now correctly shows the property name:
> 
> $ itweb-settings set unknown.property.name foo
> Unknown property-name "unknown.property.name"
> 
> Okay to commit?
> 
> As a side note: the set command is executed and a new property is 
> created whether the property name is recognized or not.
> 

I think it would be good to make this clear, so the message reads:

WARNING: Unknown property name "x" - creating new property

or something similar.

> Cheers,
> Omair

> diff -r 54077eaf4670 netx/net/sourceforge/jnlp/controlpanel/CommandLine.java
> --- a/netx/net/sourceforge/jnlp/controlpanel/CommandLine.java	Mon Feb 28 14:30:39 2011 -0500
> +++ b/netx/net/sourceforge/jnlp/controlpanel/CommandLine.java	Mon Feb 28 16:32:03 2011 -0500
> @@ -225,7 +225,7 @@
>              }
>              config.setProperty(key, value);
>          } else {
> -            System.out.println(R("CLUnknownProperty", value));
> +            System.out.println(R("CLUnknownProperty", key));
>              config.setProperty(key, value);
>          }
>  


-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37