[icedtea-web] RFC: fix typo in output of itweb-settings
Omair Majid
omajid at redhat.com
Tue Mar 1 15:43:58 PST 2011
On 03/01/2011 05:47 PM, Dr Andrew John Hughes wrote:
> On 16:38 Mon 28 Feb , Omair Majid wrote:
>> Hi,
>>
>> The attached patch fixes a typo in itweb-settings. Instead of the
>> property name, it was actually showing the property value:
>>
>> $ itweb-settings set unknown.property.name foo
>> Unknown property-name "foo"
>>
>> It now correctly shows the property name:
>>
>> $ itweb-settings set unknown.property.name foo
>> Unknown property-name "unknown.property.name"
>>
>> Okay to commit?
>>
>> As a side note: the set command is executed and a new property is
>> created whether the property name is recognized or not.
>>
>
> I think it would be good to make this clear, so the message reads:
>
> WARNING: Unknown property name "x" - creating new property
>
> or something similar.
>
Fixed in the updated patch.
Okay to commit?
Cheers,
Omair
-------------- next part --------------
A non-text attachment was scrubbed...
Name: typo-in-set-help.patch
Type: text/x-patch
Size: 1256 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110301/6e3a6083/typo-in-set-help.patch
More information about the distro-pkg-dev
mailing list