[icedtea-web] RFC: fix typo in output of itweb-settings
Omair Majid
omajid at redhat.com
Wed Mar 2 07:14:10 PST 2011
On 03/01/2011 08:39 PM, Dr Andrew John Hughes wrote:
> On 18:43 Tue 01 Mar , Omair Majid wrote:
>> On 03/01/2011 05:47 PM, Dr Andrew John Hughes wrote:
>>> On 16:38 Mon 28 Feb , Omair Majid wrote:
>>>> Hi,
>>>>
>>>> The attached patch fixes a typo in itweb-settings. Instead of the
>>>> property name, it was actually showing the property value:
>>>>
>>>> $ itweb-settings set unknown.property.name foo
>>>> Unknown property-name "foo"
>>>>
>>>> It now correctly shows the property name:
>>>>
>>>> $ itweb-settings set unknown.property.name foo
>>>> Unknown property-name "unknown.property.name"
>>>>
>>>> Okay to commit?
>>>>
>>>> As a side note: the set command is executed and a new property is
>>>> created whether the property name is recognized or not.
>>>>
>>>
>>> I think it would be good to make this clear, so the message reads:
>>>
>>> WARNING: Unknown property name "x" - creating new property
>>>
>>> or something similar.
>>>
>>
>> Fixed in the updated patch.
>>
>> Okay to commit?
>>
>
> Ok.
>
Thanks for looking over the patch! I have pushed it to HEAD.
Cheers,
Omair
More information about the distro-pkg-dev
mailing list