[icedtea-web] RFC: fix typo in output of itweb-settings

[Dr Andrew John Hughes]

On 18:43 Tue 01 Mar     , Omair Majid wrote:
> On 03/01/2011 05:47 PM, Dr Andrew John Hughes wrote:
> > On 16:38 Mon 28 Feb     , Omair Majid wrote:
> >> Hi,
> >>
> >> The attached patch fixes a typo in itweb-settings. Instead of the
> >> property name, it was actually showing the property value:
> >>
> >> $ itweb-settings set unknown.property.name foo
> >> Unknown property-name "foo"
> >>
> >> It now correctly shows the property name:
> >>
> >> $ itweb-settings set unknown.property.name foo
> >> Unknown property-name "unknown.property.name"
> >>
> >> Okay to commit?
> >>
> >> As a side note: the set command is executed and a new property is
> >> created whether the property name is recognized or not.
> >>
> >
> > I think it would be good to make this clear, so the message reads:
> >
> > WARNING: Unknown property name "x" - creating new property
> >
> > or something similar.
> >
> 
> Fixed in the updated patch.
> 
> Okay to commit?
> 
> Cheers,
> Omair

Ok.

> diff -r 11696140595f netx/net/sourceforge/jnlp/controlpanel/CommandLine.java
> --- a/netx/net/sourceforge/jnlp/controlpanel/CommandLine.java	Tue Mar 01 18:22:17 2011 -0500
> +++ b/netx/net/sourceforge/jnlp/controlpanel/CommandLine.java	Tue Mar 01 18:39:27 2011 -0500
> @@ -225,7 +225,7 @@
>              }
>              config.setProperty(key, value);
>          } else {
> -            System.out.println(R("CLUnknownProperty", value));
> +            System.out.println(R("CLWarningUnknownProperty", key));
>              config.setProperty(key, value);
>          }
>  
> diff -r 11696140595f netx/net/sourceforge/jnlp/resources/Messages.properties
> --- a/netx/net/sourceforge/jnlp/resources/Messages.properties	Tue Mar 01 18:22:17 2011 -0500
> +++ b/netx/net/sourceforge/jnlp/resources/Messages.properties	Tue Mar 01 18:39:27 2011 -0500
> @@ -403,6 +403,7 @@
>  CLDescription=Description: {0}
>  CLUnknownCommand=Unknown command {0}
>  CLUnknownProperty=Unknown property-name "{0}"
> +CLWarningUnknownProperty=WARNING: Unknown property name "{0}" - creating new property
>  CLNoIssuesFound=No issues found.
>  CLIncorrectValue=Property "{0}" has incorrect value "{1}". Possible values {2}.
>  CLListDescription=Shows a list of all property names and values that are in use by IcedTea-Web


-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37