Reviewer needed - new regression test for verifying bugs #6196102 and #5091921

[Dr Andrew John Hughes]

On 10:40 Wed 02 Mar     , Pavel Tisnovsky wrote:
> Hi all,
> 
> I'd like to add new regression test to IcedTea6 HEAD. This test verifies
> issues described in bugs #6196102 and #5091921 and also in IcedTea bug
> #352 (http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=352).
> 
> Can anybody please review this change?
> 
> The patch itself and the output of hg diff are included in attachments.
> 
> Cheers
> Pavel

Please post the ChangeLog in the body of the e-mail and attach the complete
patch once only.  It's very confusing to have two copies of the patch in
the e-mail.

Have you posted this to hotspot-dev for review?

Assuming it replicates the issue, it looks ok, though there could be less
empy lines between the comment and the body in the test case.

> diff -r 7f61b6fae9da ChangeLog
> --- a/ChangeLog	Sun Feb 27 20:11:15 2011 +0100
> +++ b/ChangeLog	Tue Mar 01 09:52:02 2011 +0100
> @@ -1,3 +1,9 @@
> +2011-02-28  Pavel Tisnovsky  <ptisnovs at redhat.com>
> +
> +	* Makefile.am: Add new patch.
> +	* patches/jtreg-hotspot-bug-6196102.patch:
> +	Added new hotspot regresion test.
> +
>  2011-02-27  Xerxes Ranby  <xerxes at zafena.se>
>  
>  	JamVM: Fix configure --enable-jamvm full bootstrap build.
> diff -r 7f61b6fae9da Makefile.am
> --- a/Makefile.am	Sun Feb 27 20:11:15 2011 +0100
> +++ b/Makefile.am	Tue Mar 01 09:52:02 2011 +0100
> @@ -325,7 +325,8 @@
>  	patches/openjdk/6663040-com.sun.awt.patch \
>  	patches/openjdk/6775317-non-AA-simple-shape-performance.patch \
>  	patches/openjdk/6766342-AA-simple-shape-performance.patch \
> -	patches/pr600-arm-jvm.cfg.patch
> +	patches/pr600-arm-jvm.cfg.patch \
> +	patches/jtreg-hotspot-bug-6196102.patch
>  
>  if !WITH_ALT_HSBUILD
>  ICEDTEA_PATCHES += \
> diff -r 7f61b6fae9da patches/jtreg-hotspot-bug-6196102.patch
> --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
> +++ b/patches/jtreg-hotspot-bug-6196102.patch	Tue Mar 01 09:52:02 2011 +0100
> @@ -0,0 +1,43 @@
> +--- /dev/null	1970-01-01 01:00:00.000000000 +0100
> ++++ openjdk/hotspot/test/runtime/6196102/LoopTest.java	2011-02-28 22:06:47.654895000 +0100
> +@@ -0,0 +1,40 @@
> ++/*
> ++ * Copyright 2011 Red Hat, Inc.  All Rights Reserved.
> ++ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> ++ *
> ++ * This code is free software; you can redistribute it and/or modify it
> ++ * under the terms of the GNU General Public License version 2 only, as
> ++ * published by the Free Software Foundation.
> ++ *
> ++ * This code is distributed in the hope that it will be useful, but WITHOUT
> ++ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> ++ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
> ++ * version 2 for more details (a copy is included in the LICENSE file that
> ++ * accompanied this code).
> ++ *
> ++ * You should have received a copy of the GNU General Public License version
> ++ * 2 along with this work; if not, write to the Free Software Foundation,
> ++ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
> ++ */
> ++
> ++
> ++
> ++/*
> ++ * @test LoopTest
> ++ * @bug 6196102 5091921
> ++ * @summary verify that loop control variable is always computed correctly
> ++ * @run main LoopTest
> ++ * @author ptisnovs at redhat.com
> ++*/
> ++public class LoopTest {
> ++    static public void main(String[] args) {
> ++        int i1 = 0;
> ++        int i2 = Integer.MAX_VALUE;
> ++        while (i1 >= 0) {
> ++            i1++;
> ++            if (i1 > i2) {
> ++                throw new RuntimeException("Failed when i1 == " + i1 + " and i2 == " + i2);
> ++            }
> ++        }
> ++    }
> ++}

> --- /dev/null	1970-01-01 01:00:00.000000000 +0100
> +++ openjdk/hotspot/test/runtime/6196102/LoopTest.java	2011-02-28 22:06:47.654895000 +0100
> @@ -0,0 +1,40 @@
> +/*
> + * Copyright 2011 Red Hat, Inc.  All Rights Reserved.
> + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> + *
> + * This code is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License version 2 only, as
> + * published by the Free Software Foundation.
> + *
> + * This code is distributed in the hope that it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
> + * version 2 for more details (a copy is included in the LICENSE file that
> + * accompanied this code).
> + *
> + * You should have received a copy of the GNU General Public License version
> + * 2 along with this work; if not, write to the Free Software Foundation,
> + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
> + */
> +
> +
> +
> +/*
> + * @test LoopTest
> + * @bug 6196102 5091921
> + * @summary verify that loop control variable is always computed correctly
> + * @run main LoopTest
> + * @author ptisnovs at redhat.com
> +*/
> +public class LoopTest {
> +    static public void main(String[] args) {
> +        int i1 = 0;
> +        int i2 = Integer.MAX_VALUE;
> +        while (i1 >= 0) {
> +            i1++;
> +            if (i1 > i2) {
> +                throw new RuntimeException("Failed when i1 == " + i1 + " and i2 == " + i2);
> +            }
> +        }
> +    }
> +}


-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37