[RFC][Icedtea-web]: Close streams after opening them.

[Andrew Haley]

On 03/08/2011 12:09 AM, Omair Majid wrote:
> On 03/07/2011 07:04 PM, Andrew Su wrote:
>>
>> ----- Original Message -----
>>>>  From: "Omair Majid"<omajid at redhat.com>
>>>>  To: "Andrew Su"<asu at redhat.com>
>>>>  On 03/07/2011 04:40 PM, Andrew Su wrote:
>>
>> +        OutputStream s = null;
>>           try {
>> -            OutputStream s = new FileOutputStream(file);
>> +            s = new FileOutputStream(file);
>>               store(s, header);
>>           } catch (IOException ex) {
>>               // eat
>> +        } finally {
>> +            try {
>> +                s.close();
>> +            } catch (IOException e) {
>> +            }
>>           }
>>       }

I realize this is in danger of turning into a bikeshed discussion,
but what happens to the code above when new FileOutputStream() throws
an exception?

Andrew.

P.S.  People, please trim your posts.  There are orders of magnitude
more readers than writers.