[RFC][Icedtea-web]: Close streams after opening them.

[Dr Andrew John Hughes]

On 10:08 Tue 08 Mar     , Andrew Haley wrote:
> On 03/08/2011 12:09 AM, Omair Majid wrote:
> > On 03/07/2011 07:04 PM, Andrew Su wrote:
> >>
> >> ----- Original Message -----
> >>>>  From: "Omair Majid"<omajid at redhat.com>
> >>>>  To: "Andrew Su"<asu at redhat.com>
> >>>>  On 03/07/2011 04:40 PM, Andrew Su wrote:
> >>
> >> +        OutputStream s = null;
> >>           try {
> >> -            OutputStream s = new FileOutputStream(file);
> >> +            s = new FileOutputStream(file);
> >>               store(s, header);
> >>           } catch (IOException ex) {
> >>               // eat
> >> +        } finally {
> >> +            try {
> >> +                s.close();
> >> +            } catch (IOException e) {
> >> +            }
> >>           }
> >>       }
> 
> I realize this is in danger of turning into a bikeshed discussion,
> but what happens to the code above when new FileOutputStream() throws
> an exception?
> 

FYI: handling these properly is what try-with-resources is for in Project Coin.

http://blogs.sun.com/darcy/entry/project_coin_updated_arm_spec

I haven't yet read this whole thread, but swallowing exceptions looks implicitly wrong.

> Andrew.
> 
> P.S.  People, please trim your posts.  There are orders of magnitude
> more readers than writers.

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37