[RFC][Icedtea-Web]: Ensure all ports entered are numeric values

[Omair Majid]

Hi,

Sorry about the late reply; somehow I must have missed this patch.

> @@ -114,6 +117,25 @@
>           addressField.getDocument().addDocumentListener(new DocumentAdapter(config, properties[1]));
>
>           final JTextField portField = new JTextField(config.getProperty(properties[2]), 3);
> +        portField.setInputVerifier(new InputVerifier() {
> +
> +            @Override
> +            public boolean verify(JComponent input) {
> +                JTextField jtf = (JTextField) input;
> +
> +                try {
> +                    String str = jtf.getText();
> +                    if (str != null&&  str.trim().length()>  0) Integer.parseInt(str);
> +                    return true;

Does this code handle numbers which are valid integers but not valid 
port numbers? From this change here, it doesn't look like it will

This is more of a stylistic concern, but I read the statement above as 
if (bunch of stuff) { return true; }. Please add parenthesis to make it 
clearer.

> +                } catch (NumberFormatException nfe) {
> +                    JOptionPane.showMessageDialog(null, Translator.R("CPInvalidPort1"));
> +                    config.setProperty(properties[2], null);

Why set to null? Wouldn't reverting to the last (known-good) value be a 
better idea?

> +                }
> +
> +                return false;
> +            }
> +
> +        });

Everything else looks fine.

Cheers,
Omair