[RFC][Icedtea-Web]: Ensure all ports entered are numeric values

[Andrew Su]

----- Original Message -----
> Hi,
> 
> Sorry about the late reply; somehow I must have missed this patch.

No problem!

> 
> > @@ -114,6 +117,25 @@
> >           addressField.getDocument().addDocumentListener(new
> >           DocumentAdapter(config, properties[1]));
> >
> >           final JTextField portField = new
> >           JTextField(config.getProperty(properties[2]), 3);
> > + portField.setInputVerifier(new InputVerifier() {
> > +
> > + @Override
> > + public boolean verify(JComponent input) {
> > + JTextField jtf = (JTextField) input;
> > +
> > + try {
> > + String str = jtf.getText();
> > + if (str != null&& str.trim().length()> 0) Integer.parseInt(str);
> > + return true;
> 
> Does this code handle numbers which are valid integers but not valid
> port numbers? From this change here, it doesn't look like it will

Similar to original implementation I proposed, this will do verification on input. It also validates whether this is a valid port in the range 1-65535 (inclusive).

v1 does not alert the user (silently ignore input).
v2 alerts the user via popup.

> 
> This is more of a stylistic concern, but I read the statement above as
> if (bunch of stuff) { return true; }. Please add parenthesis to make
> it
> clearer.

Sure.

> 
> > + } catch (NumberFormatException nfe) {
> > + JOptionPane.showMessageDialog(null,
> > Translator.R("CPInvalidPort1"));
> > + config.setProperty(properties[2], null);
> 
> Why set to null? Wouldn't reverting to the last (known-good) value be
> a
> better idea?

Completely removed in the new patches.

Regards,
  Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20110321_number_only_v1.patch
Type: text/x-patch
Size: 7205 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110321/13a2d85c/20110321_number_only_v1.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20110321_number_only_v2.patch
Type: text/x-patch
Size: 7576 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110321/13a2d85c/20110321_number_only_v2.patch