Review Request: Zero tweak

Gary Benson gbenson at redhat.com
Wed Mar 23 06:48:44 PDT 2011


Dr Andrew John Hughes wrote:
> On 23 March 2011 11:52, Gary Benson <gbenson at redhat.com> wrote:
> > IcedTea contains a now-unmaintained ARM-specific interpreter.
> > Part of that interpreter was accidentally incorporated in one
> > of the webrevs when Zero was initially imported.  It does not
> > correctly limit its behaviour to only when the ARM interpreter
> > is enabled, with the potential to cause infinite loops and
> > other tricky to debug issues.  This webrev removes this code:
> >
> >  http://cr.openjdk.java.net/~gbenson/zero-tweak/
> >
> > I don't have a bug id for this.
> 
> What is your plan for fixing this in IcedTea?  The ARM interpreter
> is no longer built with hs20 (the current alternate HotSpot used
> by default in HEAD) and I'm not sure how well it works with hs19,
> provided in the b22 tarball.

It will need to go into IcedTea as a patch.  Presumably there's
already an ARM interpreter patch it could go into?

The ARM interpreter has been broken since Shark was upstreamed,
as one of the Shark TCK fixes changed an API.  Shark went in on
OpenJDK7 b112 and OpenJDK6 b21.  

Cheers,
Gary

-- 
http://gbenson.net/



More information about the distro-pkg-dev mailing list