Review Request: Zero tweak

[Dr Andrew John Hughes]

On 13:48 Wed 23 Mar     , Gary Benson wrote:
> Dr Andrew John Hughes wrote:
> > On 23 March 2011 11:52, Gary Benson <gbenson at redhat.com> wrote:
> > > IcedTea contains a now-unmaintained ARM-specific interpreter.
> > > Part of that interpreter was accidentally incorporated in one
> > > of the webrevs when Zero was initially imported.  It does not
> > > correctly limit its behaviour to only when the ARM interpreter
> > > is enabled, with the potential to cause infinite loops and
> > > other tricky to debug issues.  This webrev removes this code:
> > >
> > >  http://cr.openjdk.java.net/~gbenson/zero-tweak/
> > >
> > > I don't have a bug id for this.
> > 
> > What is your plan for fixing this in IcedTea?  The ARM interpreter
> > is no longer built with hs20 (the current alternate HotSpot used
> > by default in HEAD) and I'm not sure how well it works with hs19,
> > provided in the b22 tarball.
> 
> It will need to go into IcedTea as a patch.  Presumably there's
> already an ARM interpreter patch it could go into?
> 

I was hoping you were going to tell me.  

>From what I can see, there is some patches that might be relevant and
also a blob of code in the arm_port directory that is copied over
during the ports target (as zero + shark used to be).  The latter is
disabled in IcedTea6 1.10 and HEAD if building hs20.  I plan to get
hs20 into b23 at which point the arm_port stuff won't even be built
any more in any configuration.  hs20 is already the default in HEAD
and so the arm_port copying is disabled by default.

>From what you say above, it sounds like this causes a major issue
on all Zero builds unless you happen to be both on ARM and building
the ARM assembler.

I have no idea how the ARM assembler is enabled but it sounds like
that code needs to be either better ifdefed or just ripped out as
in your upstream patch.

Can you look at providing a patch for this?  It sounds like it
will need to be backported to the release branches.

> The ARM interpreter has been broken since Shark was upstreamed,
> as one of the Shark TCK fixes changed an API.  Shark went in on
> OpenJDK7 b112 and OpenJDK6 b21.  
> 

So current IcedTea7 HEAD (b123), current IcedTea6 HEAD and the
IcedTea6 1.10 series (both b22) all have this broken ARM interpreter.

As I mentioned during the 1.10 release process, the ARM port will
be removed prior to 1.11 unless someone steps up to maintain it
as it won't even build any more.

> Cheers,
> Gary
> 
> -- 
> http://gbenson.net/

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37