[icedtea-web] RFC: fix make distcheck (was broken by addition of tests directory)

Dr Andrew John Hughes ahughes at redhat.com
Wed Mar 23 15:02:08 PDT 2011


On 14:46 Wed 09 Mar     , Omair Majid wrote:
> Hi,
> 
> Adding a tests directory broke 'make distcheck' - the attached patch 
> fixes it by adding tests to EXTRA_DIST.
> 
> Okay to commit?
> 
> Thanks,
> Omair

Patch seems fine.  What was the actual failure?  Presumably make check failed?

> diff -r d91d02e798ff Makefile.am
> --- a/Makefile.am	Wed Mar 09 13:51:48 2011 -0500
> +++ b/Makefile.am	Wed Mar 09 14:43:03 2011 -0500
> @@ -87,7 +87,7 @@
>  PLUGIN_VERSION = IcedTea-Web $(FULL_VERSION)
>  
>  EXTRA_DIST = $(top_srcdir)/netx $(top_srcdir)/plugin javaws.png javaws.desktop.in extra launcher \
> - itweb-settings.desktop.in
> + itweb-settings.desktop.in $(top_srcdir)/tests
>  
>  # Top-Level Targets
>  # =================


-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37



More information about the distro-pkg-dev mailing list