[icedtea-web] RFC: fix make distcheck (was broken by addition of tests directory)

Omair Majid omajid at redhat.com
Thu Mar 24 06:32:15 PDT 2011


On 03/23/2011 06:02 PM, Dr Andrew John Hughes wrote:
> On 14:46 Wed 09 Mar     , Omair Majid wrote:
>> Hi,
>>
>> Adding a tests directory broke 'make distcheck' - the attached patch
>> fixes it by adding tests to EXTRA_DIST.
>>
>> Okay to commit?
>>
>
> Patch seems fine.  What was the actual failure?  Presumably make check failed?
>

Yeah, make distcheck failed:

make[2]: Entering directory 
`/home/omajid/code/icedtea-web/build/icedtea-web-1.1pre/_build'
./jrunscript 
/home/omajid/code/icedtea-web/build/icedtea-web-1.1pre/_build/../tests/netx/pac/pac-funcs-test.js 
\
	  $(readlink -f 
/home/omajid/code/icedtea-web/build/icedtea-web-1.1pre/_build/../netx/net/sourceforge/jnlp/runtime/pac-funcs.js)
js: Couldn't read source file 
"/home/omajid/code/icedtea-web/build/icedtea-web-1.1pre/_build/../tests/netx/pac/pac-funcs-test.js: 
/home/omajid/code/icedtea-web/build/icedtea-web-1.1pre/_build/../tests/netx/pac/pac-funcs-test.js 
(No such file or directory)".
make[2]: *** [check-pac-functions] Error 4
make[2]: Leaving directory 
`/home/omajid/code/icedtea-web/build/icedtea-web-1.1pre/_build'
make[1]: *** [check-am] Error 2
make[1]: Leaving directory 
`/home/omajid/code/icedtea-web/build/icedtea-web-1.1pre/_build'
make: *** [distcheck] Error 1

Cheers,
Omair



More information about the distro-pkg-dev mailing list