[icedtea-web] RFC: fix make distcheck (was broken by addition of tests directory)

Dr Andrew John Hughes ahughes at redhat.com
Thu Mar 24 07:05:50 PDT 2011


On 09:32 Thu 24 Mar     , Omair Majid wrote:
> On 03/23/2011 06:02 PM, Dr Andrew John Hughes wrote:
> > On 14:46 Wed 09 Mar     , Omair Majid wrote:
> >> Hi,
> >>
> >> Adding a tests directory broke 'make distcheck' - the attached patch
> >> fixes it by adding tests to EXTRA_DIST.
> >>
> >> Okay to commit?
> >>
> >
> > Patch seems fine.  What was the actual failure?  Presumably make check failed?
> >
> 
> Yeah, make distcheck failed:
> 
> make[2]: Entering directory 
> `/home/omajid/code/icedtea-web/build/icedtea-web-1.1pre/_build'
> ./jrunscript 
> /home/omajid/code/icedtea-web/build/icedtea-web-1.1pre/_build/../tests/netx/pac/pac-funcs-test.js 
> \
> 	  $(readlink -f 
> /home/omajid/code/icedtea-web/build/icedtea-web-1.1pre/_build/../netx/net/sourceforge/jnlp/runtime/pac-funcs.js)
> js: Couldn't read source file 
> "/home/omajid/code/icedtea-web/build/icedtea-web-1.1pre/_build/../tests/netx/pac/pac-funcs-test.js: 
> /home/omajid/code/icedtea-web/build/icedtea-web-1.1pre/_build/../tests/netx/pac/pac-funcs-test.js 
> (No such file or directory)".
> make[2]: *** [check-pac-functions] Error 4
> make[2]: Leaving directory 
> `/home/omajid/code/icedtea-web/build/icedtea-web-1.1pre/_build'
> make[1]: *** [check-am] Error 2
> make[1]: Leaving directory 
> `/home/omajid/code/icedtea-web/build/icedtea-web-1.1pre/_build'
> make: *** [distcheck] Error 1
> 
> Cheers,
> Omair

Ah yeah as I thought, make check.

Thanks,
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37



More information about the distro-pkg-dev mailing list