[icedtea-web] RFC: handle exceptions during boot

[Omair Majid]

On 03/30/2011 06:27 PM, Dr Andrew John Hughes wrote:
> On 17:35 Wed 30 Mar     , Omair Majid wrote:
>> On 03/30/2011 04:40 PM, Dr Andrew John Hughes wrote:
>>> On 15:54 Wed 30 Mar     , Omair Majid wrote:
>>>> Hi,
>>>>
>>>> The attached patch makes the LaunchHandler handle exceptions that happen
>>>> during the parsing of the JNLP file.
>>>>
>>>> Most of the changes are simply moving things from Boot to Launcher.
>>>> Launcher, which has an associated LaunchHandler, is in a much better
>>>> position to use the LaunchHandler to inform the user about exceptions
>>>> that happen while parsing.
>>>>
>>>> I am not too happy about the name of the class InformationToMerge. Any
>>>> ideas?
>>>>
>>>
>>> It suggests to me it doesn't warrant being an object.
>>>
>>> Any particular reason you need a class at all and didn't just use an
>>> array or a map, given they all have the same type?
>>>
>>> So with a Map<String[]>, extra.getParameters() would become extra.get("parameters")
>>> and there's room for further expansion with minimal effort.
>>>
>>
>> Good point. Fixed in the attached patch.
>>
>> Any other suggestions or comments?
>>
>
> I don't see anything obvious, but it's a little hard to read with the code movement.
> Is most of the new code just moved without change?
>

No, most of the new code is new or modified quite a bit. The only things 
moved without any changes were the 
getArguments/getParameters/getProperties methods.

> If possible, it would be preferable to do the movement separately.
>

That's what I am trying to do in the patch essentially - move stuff from 
Boot to Launcher. But due to data dependencies (especially command line 
options), I have had to write some new code to pass that data around.

Okay to commit?

Cheers,
Omair