[icedtea-web] RFC: handle exceptions during boot

Dr Andrew John Hughes ahughes at redhat.com
Wed Mar 30 15:46:58 PDT 2011


On 18:36 Wed 30 Mar     , Omair Majid wrote:
> On 03/30/2011 06:27 PM, Dr Andrew John Hughes wrote:
> > On 17:35 Wed 30 Mar     , Omair Majid wrote:

snip...

> >>
> >
> > I don't see anything obvious, but it's a little hard to read with the code movement.
> > Is most of the new code just moved without change?
> >
> 
> No, most of the new code is new or modified quite a bit. The only things 
> moved without any changes were the 
> getArguments/getParameters/getProperties methods.
> 
> > If possible, it would be preferable to do the movement separately.
> >
> 
> That's what I am trying to do in the patch essentially - move stuff from 
> Boot to Launcher. But due to data dependencies (especially command line 
> options), I have had to write some new code to pass that data around.
> 
> Okay to commit?
> 

Yeah, go for it, assuming you tested it.

> Cheers,
> Omair

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37



More information about the distro-pkg-dev mailing list