Reviewer needed: second fix for regression hotspot test hotspot/test/runtime/6929067/Test6929067 for IcedTea6

[Dr Andrew John Hughes]

On 15:34 Thu 12 May     , Pavel Tisnovsky wrote:
> Hi all,
> 
> I'd like to push second version of fix for regression hotspot test
> hotspot/test/runtime/6929067/Test6929067 for IcedTea6. This fix ensures
> that this test will work on these combinations:
> 
> -32 bit JVM on an 32 bit platform
> -32 bit JVM on an 64 bit platform (pretty unusual but according to
> Oracle guys it is possible)
> -64 bit JVM on an 64 bit platform
> 

I still don't understand the second option.  I don't believe there are
any build options to get such a setup.

> hg diff for IcedTea6 is stored in an attachment. Please note that older
> patch for this test is already included in IcedTea6, so no changes has
> to be made in Makefile*.
> 
> Here is ChangeLog entry:
> 
> 2011-05-12  Pavel Tisnovsky  <ptisnovs at redhat.com>
> 
>         * patches/jtreg-6929067-fix.patch: fix this test
>         so it works on any combination of JVM and platform
>         (32 bit and 64 bit)
> 
> 
> Can anybody please review this change?
> 

Looks fine to me.  Did you manage to get it upstream or are they still playing games?

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37