Reviewer needed: second fix for regression hotspot test hotspot/test/runtime/6929067/Test6929067 for IcedTea6

[Pavel Tisnovsky]

Dr Andrew John Hughes wrote:
> On 15:34 Thu 12 May     , Pavel Tisnovsky wrote:
>> Hi all,
>>
>> I'd like to push second version of fix for regression hotspot test
>> hotspot/test/runtime/6929067/Test6929067 for IcedTea6. This fix ensures
>> that this test will work on these combinations:
>>
>> -32 bit JVM on an 32 bit platform
>> -32 bit JVM on an 64 bit platform (pretty unusual but according to
>> Oracle guys it is possible)
>> -64 bit JVM on an 64 bit platform
>>
> 
> I still don't understand the second option.  I don't believe there are
> any build options to get such a setup.

I did not manage to build 32-bit IcedTea on 64-bit JVM too, but if such
simple change will make everybody happy and it does not break anything I
 personally think it's best to be synchronized with OpenJDK (where I was
asked to change the test this way, as you probably know).

> 
>> hg diff for IcedTea6 is stored in an attachment. Please note that older
>> patch for this test is already included in IcedTea6, so no changes has
>> to be made in Makefile*.
>>
>> Here is ChangeLog entry:
>>
>> 2011-05-12  Pavel Tisnovsky  <ptisnovs at redhat.com>
>>
>>         * patches/jtreg-6929067-fix.patch: fix this test
>>         so it works on any combination of JVM and platform
>>         (32 bit and 64 bit)
>>
>>
>> Can anybody please review this change?
>>
> 
> Looks fine to me.  Did you manage to get it upstream or are they still playing games?
> 

I created webrev on Wed
(http://cr.openjdk.java.net/~ptisnovs/jtreg-runtime-test-6929067-fix2/)
and sent e-mail with review request, it took some time to respond.

Pavel