Questionable regression test LocaleEnhanceTest in IcedTea7

[Dr Andrew John Hughes]

On 16:53 Tue 17 May     , Pavel Tisnovsky wrote:
> Dr Andrew John Hughes wrote:
> > On 14:58 Tue 17 May     , Pavel Tisnovsky wrote:
> >> Hi all,
> >>
> >> Regression test LocaleEnhanceTest.java from IcedTea7 cannot be compiled
> >> because its base class LocaleTestFmwk.java is erased as "questionable"
> >> file that contains improper(?) licence.
> >>
> >> My question is what to do with LocaleEnhanceTest itself? Erase it too
> >> (ie add it to fsg.sh?)
> >>
> >> Cheers,
> >> Pavel
> > 
> > What's the path to these files?
> 
> Hi Andrew,
> 
> path is:
> openjdk/jdk/test/java/util/Locale/
> 
> here's excerpt from LocaleEnhanceTest.java:
> 
> public class LocaleEnhanceTest extends LocaleTestFmwk {
> 
> ... its based on class LocaleTestFmwk deleted by fsg.sh script.
> 
> Cheers,
> Pavel

This is the problematic license:

 * (C) Copyright Taligent, Inc. 1996, 1997 - All Rights Reserved                                                               
 * (C) Copyright IBM Corp. 1996 - 1999 - All Rights Reserved                                                                    *                                                                                                                             
 * Portions copyright (c) 2007 Sun Microsystems, Inc.                                                                          
 * All Rights Reserved.                                                                                                        
 *                                                                                                                             
 * The original version of this source code and documentation                                                                  
 * is copyrighted and owned by Taligent, Inc., a wholly-owned                                                                  
 * subsidiary of IBM. These materials are provided under terms                                                                 
 * of a License Agreement between Taligent and Sun. This technology                                                            
 * is protected by multiple US and International patents.                                                                      
 *                                                                                                                             
 * This notice and attribution to Taligent may not be removed.                                                                 
 * Taligent is a registered trademark of Taligent, Inc.                                                                        
 *                                                                                                                             
 * Permission to use, copy, modify, and distribute this software                                                               
 * and its documentation for NON-COMMERCIAL purposes and without                                                               
 * fee is hereby granted provided that this copyright notice                                                                   
 * appears in all copies. Please refer to the file "copyright.html"                                                            
 * for further important copyright and licensing information.                                                                  
 *                                                                                                                             
 * SUN MAKES NO REPRESENTATIONS OR WARRANTIES ABOUT THE SUITABILITY OF                                                         
 * THE SOFTWARE, EITHER EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED                                                          
 * TO THE IMPLIED WARRANTIES OF MERCHANTABILITY, FITNESS FOR A                                                                 
 * PARTICULAR PURPOSE, OR NON-INFRINGEMENT. SUN SHALL NOT BE LIABLE FOR                                                         * ANY DAMAGES SUFFERED BY LICENSEE AS A RESULT OF USING, MODIFYING OR                                                          * DISTRIBUTING THIS SOFTWARE OR ITS DERIVATIVES.                                                                               *                                                                                                                              */

IANAL, but the 'NON-COMMERCIAL' provision clearly makes this non-Free.

There is a standard Oracle GPLv2+Classpath exception license above it
so I'm not sure what's going on here.  We need someone from Oracle to
clarify this.

In the meantime, doesn't jtreg have an 'ignore' facility so we can
set the dependent test as to be ignored with an appropriate reason?
Then we can just turn it back on if this class is allowed back in.
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37