Reviewer needed: fix for regression test test/com/sun/org/apache/xml/internal/ws/server/Test.java

[Dr Andrew John Hughes]

On 11:29 Fri 20 May     , Pavel Tisnovsky wrote:
> Hi all,
> 
> I'd like to push fix for patch using to create regression test
> /test/com/sun/org/apache/xml/internal/ws/server/Test.java to IcedTea7.
> 
> The existing patch "patches/security/6592792.patch" creates only one
> part of this test, but it does not contain shell script used to run the
> test itself. hg diff containing fixed patch is stored in an attachment.
> 
> Here's ChangeLog entry:
> 
> 2011-05-20  Pavel Tisnovsky  <ptisnovs at redhat.com>
> 
>         * patches/security/6592792.patch:
>         Added missing script used to start this regression test.
> 
> 
> Can anybody review it please?
> 
> Thank you in advance,
> Pavel

I think you attached the wrong patch.

I'm not sure how viable that patch even is, but it's hard to find anyone
to ask about old security patches.

> # HG changeset patch
> # User ptisnovs
> # Date 1305881214 -7200
> # Node ID e7c2a6393dac8ccab64e834e0befdd859026cea0
> # Parent  1af45d3c1f92c24aa74ad62efa229bef60617869
> Added LocaleEnhanceTest to regression test exclude list.
> 
> diff -r 1af45d3c1f92 -r e7c2a6393dac test/jtreg/excludelist.jdk.jtx
> --- a/test/jtreg/excludelist.jdk.jtx	Fri May 20 03:23:45 2011 +0100
> +++ b/test/jtreg/excludelist.jdk.jtx	Fri May 20 10:46:54 2011 +0200
> @@ -197,3 +197,9 @@
>  java/awt/FontClass/CreateFont/fileaccess/FontFile.java
>  java/awt/FontClass/CreateFont/DeleteFont.sh
>  java/awt/FontClass/CreateFont/bigfont.html
> +
> +# This test cannot be compiled because it's base class
> +# LocaleTestFmwk is deleted during the "liberation" phase
> +# of build process (this class has questionable licence).
> +java/util/Locale/LocaleEnhanceTest.java
> +


-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37