Reviewer needed: fix for regression test test/com/sun/org/apache/xml/internal/ws/server/Test.java

[Pavel Tisnovsky]

Dr Andrew John Hughes wrote:
> On 11:29 Fri 20 May     , Pavel Tisnovsky wrote:
>> Hi all,
>>
>> I'd like to push fix for patch using to create regression test
>> /test/com/sun/org/apache/xml/internal/ws/server/Test.java to IcedTea7.
>>
>> The existing patch "patches/security/6592792.patch" creates only one
>> part of this test, but it does not contain shell script used to run the
>> test itself. hg diff containing fixed patch is stored in an attachment.
>>
>> Here's ChangeLog entry:
>>
>> 2011-05-20  Pavel Tisnovsky  <ptisnovs at redhat.com>
>>
>>         * patches/security/6592792.patch:
>>         Added missing script used to start this regression test.
>>
>>
>> Can anybody review it please?
>>
>> Thank you in advance,
>> Pavel
> 
> I think you attached the wrong patch.

Hmm you are right, but anyway I realized that there are two patches
named 6592792.patch. The first one is stored in
patches/security/6592792.patch and is really applied (according to
Makefile) and the second one is stored in patches/6592792.patch and is
not applied. I'd rather to copy part of the second patch (only test
script) to the first one and then IMHO the second patch could be erase.
Any idea?

Cheers,
Pavel


> 
> I'm not sure how viable that patch even is, but it's hard to find anyone
> to ask about old security patches.
>