[RFC][Icedtea-Web]: PR727 Fix deleting of incorrect file when cleaning cache.

Omair Majid omajid at redhat.com
Thu May 26 15:48:07 PDT 2011


On 05/26/2011 06:04 PM, Andrew Su wrote:
> Hello,
>
> This patch fixes PR727 [1].
>
> What was happening before was that when we say we want to keep a
> file, but it exists again in the list of recently used files, it will
> add it to remove.
>

Hm... why does one entry appear multiple times? Shouldn't we be 
addressing that instead?

I am a little confused by the current code. The current logic is
if (delete || keep.contains(...)) {
   ...
}
Which I find a little strange (we are treating stuff to delete and stuff 
to keep equally?). Your patch certainly makes it look a little more sane.

I see that you are adding a NEWS entry with a different description than 
on the bug. Would you mind updating the bug report itself?

Thanks,
Omair



More information about the distro-pkg-dev mailing list